-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build NVDA with Python 3.8 32-bit #12042
Conversation
The latest version of Python 3.7 is 3.7.9 (as of February 2021). Therefore remove 3.7.6 check.
See test results for failed build of commit 6301195cec |
scons.bat
Outdated
@@ -6,7 +6,7 @@ where py 1>nul 2>&1 | |||
if "%ERRORLEVEL%" == "0" ( | |||
rem Python launcher is present in the PATH | |||
rem Call python 3.7 for 32 bits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade this comment to mention Python 3.8
Hi, it is already targeting py3.8 branch, and I can take care of other comments today. Thanks.
From: Łukasz Golonka <[email protected]>
Sent: Saturday, February 6, 2021 7:23 AM
To: nvaccess/nvda <[email protected]>
Cc: Joseph Lee <[email protected]>; Author <[email protected]>
Subject: Re: [nvaccess/nvda] SConstruct: build NVDA with Python 3.8 32-bit (#12042)
The copyright header upgrade would conflict with the work from #11967 <#11967> and since #11967 <#11967> is almost certainly going to be merged before this PR it makes sense to revert it. Have you considered re-targeting this to the py3.8 branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#12042 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEBX6P6KET2RX6VSC4LS5VNGDANCNFSM4XFIWFSQ> .
|
Please double check - for me GitHub shows Master as a target branch. |
Corrected.
|
This reverts commit 096f61b due to impending Py2Exe upgrade that will update copyright header.
I have taken the opportunity to change readme.md and appveyor.yml in this pr to mention/use Python 3.8, as it makes sense to change sconstruct, readme and appveyor all at once when we merge this to the py3.8 branch. However, we do not expect the py3.8 branch to actualy run with appveyor yet though as there are several large dependencies that much also change, which will be done in separate prs. |
Hi,
Required to build NVDA under Python 3.8:
Link to issue number:
None
Summary of the issue:
Currently SConstruct runs Python 3.7 to build NVDA.
Description of how this pull request fixes the issue:
Directs SConstruct to build NVDA under Python 3.8 32-bit.
Testing strategy:
Known issues with pull request:
None
Change log entry:
None
Code Review Checklist:
As this is an internal change, only applicable tests are shown:
Note: system tests is excluded as it is not really required to build the PR build until AppVeyor is ready to run Python 3.8 to build NvDA.
Thanks.